Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): normalize input for poll option #8342

Merged
merged 4 commits into from
Nov 17, 2022
Merged

fix(core): normalize input for poll option #8342

merged 4 commits into from
Nov 17, 2022

Conversation

mhnaeem
Copy link
Contributor

@mhnaeem mhnaeem commented Nov 15, 2022 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This change normalizes input for the poll option to either a boolean or number to meet the specs required by Webpack config

Fixes #8306

Test links

Deploy preview: https://deploy-preview-8342--docusaurus-2.netlify.app/

Related issues/PRs

#8306
#6722

@mhnaeem
fix(core): normalize input for poll option
89471c3 
This change normalizes input for the poll option to either a boolean or number to meet the specs required by Webpack config

fixes facebook#8306
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 15, 2022
@netlify
Copy link

netlify bot commented Nov 15, 2022 •
edited
Loading

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 75e2a39
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/637545abe4e6c3000910e3b0
😎 Deploy Preview https://deploy-preview-8342--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 92 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 69 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber
Copy link
Collaborator

slorber commented Nov 16, 2022

LGTM thanks 👍

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Nov 16, 2022
@mhnaeem
fix(core): normalize input for poll option
0efb26d 
This change normalizes input for the poll option to either a boolean or number to meet the specs required by Webpack config.
Move the function into the docusaurus.mjs file as requested.

fixes facebook#8306
@Josh-Cena
Copy link
Collaborator

LGTM

@slorber slorber merged commit 53aa9a2 into facebook:main Nov 17, 2022
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Nov 17, 2022
slorber pushed a commit that referenced this pull request Jan 26, 2023
@mhnaeem @slorber
fix(core): normalize input for poll option (#8342)
0294171 
Fixes #8306
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 27, 2023
@slorber slorber mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@slorber slorber Awaiting requested review from slorber slorber is a code owner

Assignees
No one assigned
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use hot reloading in Docker (continuation of #6722)
4 participants
@mhnaeem @slorber @Josh-Cena @facebook-github-bot