Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(theme-translations): complete French translations #8243

Merged
merged 1 commit into from
Oct 26, 2022
Merged

chore(theme-translations): complete French translations #8243

merged 1 commit into from
Oct 26, 2022

Conversation

forresst
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Complete translations in French

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 25, 2022
@netlify
Copy link

netlify bot commented Oct 25, 2022

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 2daa6c2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63579eccaee9920008cf19f6
😎 Deploy Preview https://deploy-preview-8243--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 62 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 80 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Oct 26, 2022
@slorber
Copy link
Collaborator

slorber commented Oct 26, 2022

LGTM thanks 👍

@slorber slorber merged commit 327158b into facebook:main Oct 26, 2022
@forresst forresst deleted the theme-translations-french-translations branch October 26, 2022 11:18
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Oct 26, 2022
slorber pushed a commit that referenced this pull request Oct 28, 2022
@forresst @slorber
chore(theme-translations): complete French translations (#8243)
51ba455
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
@slorber slorber mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forresst @slorber @facebook-github-bot