Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removing community resource docusaurus-plugin-relative-paths #8209

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

ShahriarKh
Copy link
Contributor

@ShahriarKh ShahriarKh commented Oct 13, 2022

Removing docusaurus-plugin-relative-paths from resources since the plugin no longer exists.

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

Removing docusaurus-plugin-relative-paths from resources since the plugin no longer exists.
@ShahriarKh ShahriarKh changed the title Removing docusaurus-plugin-relative-paths docs: removing docusaurus-plugin-relative-paths Oct 13, 2022
@netlify
Copy link

netlify bot commented Oct 13, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 5612712
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/634802fb05c2f900095df73f
😎 Deploy Preview https://deploy-preview-8209--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 94 🟢 98 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 87 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber
Copy link
Collaborator

slorber commented Oct 13, 2022

The plugin still exist on npm though: https://www.npmjs.com/package/@someok/docusaurus-plugin-relative-paths

@ohkimur why did you delete it?

@ohkimur
Copy link
Contributor

ohkimur commented Oct 13, 2022

@slorber It didn't provide enough value to be worth the time invested to maintain it.

@slorber
Copy link
Collaborator

slorber commented Oct 13, 2022

Thanks, up to you but in this case you can simply archive the repo, which makes it easier for others to take your work over

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 13, 2022
@slorber slorber changed the title docs: removing docusaurus-plugin-relative-paths docs: removing community resource docusaurus-plugin-relative-paths Oct 13, 2022
@slorber
Copy link
Collaborator

slorber commented Oct 13, 2022

@ShahriarKh I will need you to sign the Facebook CLA to be able to merge. I know this is annoying but this is mandatory, repo settings do not allow me to merge without it

@ShahriarKh
Copy link
Contributor Author

@ShahriarKh I will need you to sign the Facebook CLA to be able to merge. I know this is annoying but this is mandatory, repo settings do not allow me to merge without it

Done

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 14, 2022
@slorber slorber merged commit d2fdd98 into facebook:main Oct 14, 2022
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants