Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-docusaurus): tutorial and init template improvements #8032

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 1, 2022

Motivation

The tutorial explicit sidebar must contain the tutorial-basics/create-a-document doc, so that the sidebar remains visible while browsing the doc suggesting to create that manual sidebar in the first place. See also feedback #4610 (comment)

Also mention site config + themeConfig in the extras

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 1, 2022
@netlify
Copy link

netlify bot commented Sep 1, 2022

[V2]

Name Link
🔨 Latest commit b65fbf1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63108e1923fe680008ef9995
😎 Deploy Preview https://deploy-preview-8032--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 77 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 76 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber added pr: documentation This PR works on the website or other text documents in the repo. pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus labels Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Size Change: 0 B

Total Size: 814 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.5 kB
website/build/assets/css/styles.********.css 111 kB
website/build/assets/js/main.********.js 610 kB
website/build/index.html 40.9 kB

compressed-size-action

@slorber slorber merged commit 55de3ea into main Sep 1, 2022
@slorber slorber deleted the slorber/tutorial-improvements branch September 1, 2022 11:10
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release. pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants