You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
changed the title
feat(theme): ability to use <DocCardList> propless, on any doc page
feat(theme): ability to use <DocCardList> without items prop, on any doc page
Aug 25, 2022
This is very nice. I would definitely keep supporting items—from a design perspective, I always prefer using props to context where possible since that makes the dependency explicit. Keeping it means the component may be used as a pure design system component instead of being coupled to any context.
This is very nice. I would definitely keep supporting items—from a design perspective, I always prefer using props to context where possible since that makes the dependency explicit. Keeping it means the component may be used as a pure design system component instead of being coupled to any context.
yes I'm fine to keep it! although not sure in which case you'd want to use it, curious to know ;)
slorber
added
backported
This PR has been backported to a stable version of Docusaurus
and removed
to backport
This PR is planned to be backported to a stable version of Docusaurus
labels
Sep 28, 2022
backportedThis PR has been backported to a stable version of DocusaurusCLA SignedSigned Facebook CLApr: new featureThis PR adds a new API or behavior.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It's annoying to have to write:
when it could just be:
Also it should be possible to use it on regular docs too, not just category index pages:
items
prop is kept for retro compatibility but undocumented. Maybe we'll want to remove it later unless someone comes up with a use-case for itTest Plan
unit tests + dogfood in our doc
retrocompatible: old docs version still use the
items
prop + hookTest links
Deploy preview: