-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow customizing localization path of each locale #7624
Conversation
Size Change: +66 B (0%) Total Size: 801 kB
ℹ️ View Unchanged
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
That could be nice to add tests some basic "load()" tests that we currently don't have
I'm thinking of something simple like this?
import loadSetup from '../../server/__tests__/testUtils';
describe('load site', () => {
it('simple', async () => {
const props = await loadSetup('simple');
expect(props).toMatchSnapshot()
});
it('custom', async () => {
const props = await loadSetup('simple');
expect(props).toMatchSnapshot()
});
it('i18n', async () => {
const props = await loadSetup('i18n');
expect(props).toMatchSnapshot()
});
});
Also worth adding tests on the docs plugin, where you make a fixture use like i18n-custom/fr-custom
or something?
thanks 👍 |
Pre-flight checklist
Motivation
Continuation of #7386. Not sure how to test this, though...
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs