-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(content-pages): add article wrapper around MDXContent #7595
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
hey @matkoch , that looks like a reasonable change yet 👍 BTW where did you find this link? because that repo is archived, and you can now configure yourself the crawler The recommended config is here: https://docsearch.algolia.com/docs/templates/#docusaurus-v2-template |
@slorber I haven't applied yet for the updated plan / automatic crawling. Currently, I'm still crawling through a Docker container. Are there any other disadvantages? The config is linked from here: https://docsearch.algolia.com/docs/legacy/run-your-own#create-a-new-configuration |
@shortcuts any idea why the new doc does not mention anymore how to run your own Docker crawler? |
@slorber the documentation is still available under the |
Thanks. So what I understand is that running your own scrapper locally is now deprecated without replacement? Are users supposed to all migrate to the online crawler? Because we link to this page in our doc, wonder if we should keep it: https://docsearch.algolia.com/docs/legacy/run-your-own/ |
We won't maintain or provide new features to it, but accept/review community contributions if any. We also won't break the records shape required to make DocSearch UI (frontend) work, so this scraper can still be recommended and used.
For users that are eligible to the DocSearch program, yes
It's a good alternative (or starting point) for users that don't have access to the Algolia Crawler, and it correctly crawls website and return records so I'd say it's worth keeping it! |
Ok thanks :) |
Pre-flight checklist
Motivation
When I create a simple page according to this, the content is not wrapped in an
<article>
tag... therefore it's also not indexed through the default configuration that I've found.Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs