Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the padding of the p tag inside the blockquote tag #711

Merged
merged 2 commits into from
May 31, 2018

Conversation

balloob
Copy link
Contributor

@balloob balloob commented May 31, 2018

Motivation

Extra padding in quote block makes all the text not vertically aligned. Looks weird.

image

Have you read the [Contributing Guidelines on pull requests]

Yes

Test Plan

Linking to a page in the netlify preview deploy that shows the padding removed.

Related PRs

None

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 31, 2018
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented May 31, 2018

Deploy preview for docusaurus-preview ready!

Built with commit efdbba9

https://deploy-preview-711--docusaurus-preview.netlify.com

@balloob
Copy link
Contributor Author

balloob commented May 31, 2018

Test plan failed. CSS Specificity rules strike again.

image

@balloob
Copy link
Contributor Author

balloob commented May 31, 2018

image

Beautiful.

Especially 1 line quoteblocks look a lot better.

Before:
image

After:
image

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! That extra space at the top has always been an eyesore to me. Thanks for fixing it!

@yangshun yangshun merged commit b3d59f8 into facebook:master May 31, 2018
@balloob balloob deleted the patch-2 branch May 31, 2018 03:38
@balloob
Copy link
Contributor Author

balloob commented May 31, 2018

🎉 💃 🌮

@JoelMarcey
Copy link
Contributor

Excellent. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants