-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(theme-classic): split sidebar into smaller parts #6844
Conversation
✔️ [V2] 🔨 Explore the source changes: 34722fd 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/622a0f26079ab300094ac0b6 😎 Browse the preview: https://deploy-preview-6844--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6844--docusaurus-2.netlify.app/ |
Size Change: -228 B (0%) Total Size: 792 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense! Will we port the same structure to Navbar
and Footer
?
Yes that's the goal, going to open other similar PRs to other parts of the theme. Is this PR good enough to merge for you? |
Yes 👍 You can merge this if you are ready |
ok the CI is failing due to Node 17.7: nodejs/node#42279 Will fix to use 17.6 temporarily |
hmm looks useless to care about it, the fix is released very soon: nodejs/node#42285 |
Motivation
This should help to customize the sidebar with swizzling.
For example to add sticky sidebar ads as requested here: #5468 (comment)
Also reduce content to eject for some other customizations such as https://docs.dyte.io/
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
preview
dogfood sidebar content wrapping on test instance
https://deploy-preview-6844--docusaurus-2.netlify.app/tests/docs
Notes:
@Josh-Cena any opinion?