Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up some code #619

Closed
wants to merge 6 commits into from

Conversation

InternetExplorer7
Copy link
Contributor

@InternetExplorer7 InternetExplorer7 commented Apr 29, 2018

Motivation

Clean up some component.

Have you read the Contributing Guidelines on pull requests?

ya.

Test Plan

Basically moved a complicated map function to outside of render's return.

Explantation

I chose this chunk of code smell because I wanted to reduce the amount of code inside of render's return, which should mostly contain just markup and as little logic in it as possible.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 29, 2018
@yangshun
Copy link
Contributor

Thanks for the PR! Unfortunately, mapping to a component is not really considered logic, more like configuration. Moving the initialization of the component out of render also doesn't really add much value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants