fix(theme-common): useLocationChange fire un-necessarily twice #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 8b8ddfd 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61b0ccd5a865670007e5d25a 😎 Browse the preview: https://deploy-preview-6070--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6070--docusaurus-2.netlify.app/ |
|
Size Change: +7 B (0%) Total Size: 657 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix little issue reported by @lex111 here: #5714 (comment)
The
useLocationChangealways fires again on the very first re-renderHave you read the Contributing Guidelines on pull requests?
yes
Test Plan
preview (tried to write tests but ReactRouter makes this quite hard,
<StaticRouter>can't update location :s