Make sure the sitemap in footer is left aligned #509
Conversation
ryzokuken
changed the title
|
@ryzokuken Thanks for the PR! |
There was a problem hiding this comment.
@ryzokuken Just wanted to ask - did you follow the steps in #485 to make sure that the footer did not shift to the right any longer?
Also, does your change also look good on non-mobile as well --- i.e., desktop browsing.
|
@JoelMarcey I did and the footer didn't shift to the right any longer on mobile view, but I just checked in desktop view and realized that the footer looks a little shifted towards the left on non-mobile. Making that fix in a minute. |
|
@JoelMarcey I realized that there was a media query for smaller devices inside the file and it changed how the footer looked (thus making the broken transition). I made the change there and now it looks perfect. Thanks for pointing out the error, I had totally missed it. |
|
Screenshots |
|
Okay, I just found out that there's a horizontal scrollbar problem (even on the original site). Should I make a new PR for that? |
@ryzokuken Would love a new PR for that fix, thanks! |
|
I have tested in isolation the "not yet released" fix from commits d16d2aa & a7acc7d that respectively fix #518 right after #485 and it works like a charm on mobile and desktop: footer does not shift to the right any longer and no problem with horizontal scrollbar anymore. @ryzokuken Well done 👍 , thanks! |
Fixes: #485
This had been claimed 5 days ago, but there had been no response so I decided to submit a PR. This is my first one, so let me know if I made any errors, I'll make sure to take care of them.
Preview: