Allow multiple - in a version string
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we were assuming that there would be no `-` in a version. That was breaking things. This allows more flexibility for versions like: 1.0.0-beta.2 Ref facebook#455 Fixes facebook#450
|
@iRoachie Here you go. Wanna give this a run to see if it fixes your issues? |
|
Alright! After deep debugging, this fix definitely works. However I did discover something along the way. If any of your |
|
@iRoachie Thanks for the chat on Discord. We figured out my fix wasn't complete. Needed a bit more checking. |
iRoachie
approved these changes
Feb 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450
Motivation
Right now we were assuming that there would be no
-in a version.That was breaking things.
This allows more flexibility for versions like:
1.0.0-beta.2
Test Plan
Was able to successfully build versions that contained multiple dashes
Related PRs
Ref #455