-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make font-family as configurable parameter(#220) #294
Conversation
We look for fonts object within siteConfig.js
@cowlingj Thank you very much for this PR to fix the currently hard coded Did you try, locally, using your new approach in |
@cowlingj Hi. Just pinging to see what site you tested this change on? Thanks! |
I've tested both, first adding custom fonts in the |
My Prettier work here is becoming a bit funny. I will get it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cowlingj I am going to merge this in now. Thank you very much!
Motivation
issue: #220
Test Plan