[BREAKING] Rename Marked to MarkdownBlock #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelMarcey
suggested changes
Oct 24, 2017
|
Rebased. |
|
This is good to go. I think it's alright to use |
|
It's a small breaking change, so we can hold off on merging until we deploy a new package. |
vjeux
approved these changes
Oct 26, 2017
| @@ -239,7 +239,7 @@ function execute(port) { | |||
| if (metadata.layout && siteConfig.layouts[metadata.layout]) { | |||
| Doc = siteConfig.layouts[metadata.layout]({ | |||
| React, | |||
| Marked: require("../core/Marked.js") | |||
| MarkdownBlock: require("../core/MarkdownBlock.js") | |||
There was a problem hiding this comment.
I'm the only one to use this, feel free to merge and i'll update my code. I have to work anyway to deal with the hljs migration.
There was a problem hiding this comment.
Maybe we should export CompLibrary here instead?
JoelMarcey
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change that renames the Marked component, which is exposed to clients via CompLibrary, to MarkdownBlock. This moves us away from exposing internal implementation details to clients, and gives us flexibility to change markdown parsing/rendering engines in the future.
This is built on top of the
remarkablebranch, therefore #153 should be merged first.