chore: fix formatLighthouseReport() CI #10527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: internal
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Since it's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Google won't store Lighthouse reports anymore (temporarily or definitively? 🤷♂️ ) leading to the
linksparameter being always empty{}.I refactored the Markdown comment formatting function so that it can handle that case and temporarily fix the CI until we know more about Google plans
See:
Test Plan
CI
Test links
https://deploy-preview-10527--docusaurus-2.netlify.app/