Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix setup-node, use LTS by default #10438

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 23, 2024

Motivation

  • fix continous-release not using setup-node, using Node 18 instead of Node 22
  • consistently use lts everywhere when we don't care
  • e2e matrix: restore usage of node 22 instead of 22.4 (due to 22.5.0 bug)

Test Plan

CI

Test links

https://deploy-preview-10438--docusaurus-2.netlify.app/

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Aug 23, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 23, 2024
Copy link

netlify bot commented Aug 23, 2024

[V2]

Name Link
🔨 Latest commit 5f75f8a
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66c8756ae2cd2000088cd295
😎 Deploy Preview https://deploy-preview-10438--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 64 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 53 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 69 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 71 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@slorber slorber merged commit afd2374 into main Aug 23, 2024
30 checks passed
@slorber slorber deleted the slorber/setup-node-ci-fix branch August 23, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants