Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle React v18.3 warnings #10079

Merged
merged 17 commits into from
Apr 29, 2024
Merged

fix: handle React v18.3 warnings #10079

merged 17 commits into from
Apr 29, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 26, 2024

Motivation

React 19 is coming

They released v18.3 with extra deprecation warnings to prepare for v19.

See also https://react.dev/blog/2024/04/25/react-19-upgrade-guide

I'm not requiring Docusaurus v3 to upgrade v18.3. Instead I bump our monorepo dependency so that we can see and fix the warnings we have, ensuring our users won't see them on their sites when they upgrade React.

So far:

Warning: LoadableComponent uses the legacy contextTypes API which is no longer supported and will be removed in the next major release. Use React.createContext() with static contextType instead.
Learn more about this warning here: https://reactjs.org/link/legacy-context

Test Plan

CI

Test links

https://deploy-preview-10079--docusaurus-2.netlify.app/

@slorber slorber requested a review from Josh-Cena as a code owner April 26, 2024 10:58
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 26, 2024
@slorber slorber added pr: bug fix This PR fixes a bug in a past release. Argos Add this label to run UI visual regression tests. See argos.yml GH action. labels Apr 26, 2024
Copy link

netlify bot commented Apr 26, 2024

[V2]

Name Link
🔨 Latest commit e0d8c18
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/662ff68d16fcd90008f10d6b
😎 Deploy Preview https://deploy-preview-10079--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 26, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 49 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 70 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 71 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

argos-ci bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 144 changed Apr 29, 2024, 7:42 PM

Copy link

github-actions bot commented Apr 26, 2024

Size Change: -243 B (0%)

Total Size: 1.59 MB

Filename Size Change
website/build/assets/js/main.********.js 810 kB -243 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/codeTranslations.json 2 B
website/.docusaurus/docusaurus.config.mjs 26.7 kB
website/.docusaurus/globalData.json 91.2 kB
website/.docusaurus/i18n.json 930 B
website/.docusaurus/registry.js 247 kB
website/.docusaurus/routes.js 156 kB
website/.docusaurus/routesChunkNames.json 109 kB
website/.docusaurus/site-metadata.json 2.17 kB
website/build/assets/css/styles.********.css 113 kB
website/build/index.html 38 kB

compressed-size-action

@slorber slorber merged commit ca33858 into main Apr 29, 2024
32 checks passed
@slorber slorber deleted the slorber/react-18.3 branch April 29, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants