-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to TypeScript 5.4 #10076
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
Hey @slorber I landed here because of the reference I found in code: docusaurus/packages/docusaurus-mdx-loader/src/processor.ts Lines 25 to 31 in b6644d8
I wonder if that type can be cleaned up now? Context: |
@csantos-nydig you can do the cleanup in your own codebase But we can't do it on Docusaurus because it would emit d.ts files with newer TS features which require all users to upgrade TS (breaking change). We'll do the cleanup for the next major version. |
Motivation
Upgrade to latest TS stable version
Note: I'm not yet using mode-resolution (ttps://github.com/microsoft/TypeScript/issues/49721) (TS 5.3) because:
Test Plan
CI + min/max range tests (see #10063)
Test links
https://deploy-preview-10076--docusaurus-2.netlify.app/