-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when run "npm run build", index.html file only exists in build/xxx/en/ dir, but not copied to the root dir #468
Comments
Hi @loveky! Interesting. I followed your process and I see an |
Same issue here. |
I just tried doing the same on another machine, using just the default example and can reproduce this behavior. |
I just checked again, this time using WSL (Windows Subsystem for Linux), because I had already suspected it might be due to a Windows specific bug. Sure enough, there it generates the correct output. |
Curious. I spend some time debugging the issue via VS Code earlier this morning. Changing writeFileAndCreateFolder(targetFile.replace('/en/', '/'), str); to writeFileAndCreateFolder(targetFile.replace('en', '/'), str); Seems to fix the issue. Albeit that's clearly a hack and the proper way to fix this would probably just involve implementing the fix on line 437. Namely, |
We want to be more robust in our path string handling in order to not fail on various platforms. Fixes facebook#468
@Happy-Ferret Hi. Would you mind integrating #490 into your local repo and see if it fixes this problem for you? |
I'll gladly test it once I'm back at the office, two hours from now. |
We want to be more robust in our path string handling in order to not fail on various platforms. Fixes facebook#468
Is this a bug report?
Not Sure
Have you read the Contributing Guidelines?
Yes
Environment
Windows 7
Node 6.9.5
npm 3.10.10
Steps to Reproduce
(Write your steps here:)
npm run build
build
directoryExpected Behavior
Want to see my
index.html
file inbuild/my-site-name/
directory. This behavior is documented at HEREActual Behavior
the
index.html
only appears inbuild/my-site-name/en
directoryReproducible Demo
Pleace check Steps to Reproduce
The text was updated successfully, but these errors were encountered: