restore useScrollPosition deps

facebook · Oct 15, 2021 · ef656a1 · ef656a1
1 parent 4b23d48
commit ef656a1
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/docusaurus-theme-common/src/utils/scrollUtils.tsx b/packages/docusaurus-theme-common/src/utils/scrollUtils.tsx
@@ -99,6 +99,7 @@ export function useScrollPosition(
     position: ScrollPosition,
     lastPosition: ScrollPosition | null,
   ) => void,
+  deps: unknown[] = [],
 ): void {
   const {scrollEventsEnabledRef} = useScrollController();
   const lastPositionRef = useRef<ScrollPosition | null>(getScrollPosition());
@@ -127,7 +128,12 @@ export function useScrollPosition(
     window.addEventListener('scroll', handleScroll, opts);
 
     return () => window.removeEventListener('scroll', handleScroll, opts);
-  }, [dynamicEffect, scrollEventsEnabledRef]);
+  }, [
+    dynamicEffect,
+    scrollEventsEnabledRef,
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    ...deps,
+  ]);
 }
 
 type UseScrollPositionSaver = {