cleanUrl of '/index.html' should be '/'

facebook · Aug 28, 2018 · 6e02c49 · 6e02c49
1 parent 8633e00
commit 6e02c49
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/core/__tests__/utils.test.js b/lib/core/__tests__/utils.test.js
@@ -52,8 +52,10 @@ describe('utils', () => {
     expect(cleanPath('/en/users')).toBe('/en/users');
     expect(cleanPath('/docs/versioning.html')).toBe('/docs/versioning');
     expect(cleanPath('/en/users.html')).toBe('/en/users');
-    expect(cleanPath('/docs/en/asd/index.html')).toBe('/docs/en/asd');
-    expect(cleanPath('/en/help/index.html')).toBe('/en/help');
+    expect(cleanPath('/docs/en/asd/index.html')).toBe('/docs/en/asd/');
+    expect(cleanPath('/en/help/index.html')).toBe('/en/help/');
+    expect(cleanPath('/index.html')).toBe('/');
+    expect(cleanPath('/react/index.html')).toBe('/react/');
     expect(cleanPath('/en/help.a.b.c.d.e.html')).toBe('/en/help.a.b.c.d.e');
     expect(cleanPath('/en/help.js')).toBe('/en/help.js');
     expect(cleanPath('/test.md')).toBe('/test.md');

diff --git a/lib/core/utils.js b/lib/core/utils.js
@@ -24,7 +24,7 @@ function getPath(pathStr, cleanUrl = false) {
     return pathStr;
   }
   return pathStr.endsWith('/index.html')
-    ? pathStr.replace(/\/index.html$/, '')
+    ? pathStr.replace(/index\.html$/, '')
     : removeExtension(pathStr);
 }