Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #945

Merged
merged 2 commits into from
Oct 22, 2016
Merged

Update dependencies #945

merged 2 commits into from
Oct 22, 2016

Conversation

fson
Copy link
Contributor

@fson fson commented Oct 22, 2016

No description provided.

We dogfood on our eslint-config-react-app by using it as our ESLint config,
but installing it from the local folder causes problems when its peerDependencies
are updated, because npm won't update it unless the version number changes.

Use the published version for dogfooding so it can be installed from npm.
@fson fson force-pushed the update-dependencies branch from 78de801 to 3addfb9 Compare October 22, 2016 19:08
@fson fson merged commit d5de99e into master Oct 22, 2016
@fson fson deleted the update-dependencies branch October 22, 2016 19:36
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
* Update dependencies

* Use published version of eslint-config-react-app for development

We dogfood on our eslint-config-react-app by using it as our ESLint config,
but installing it from the local folder causes problems when its peerDependencies
are updated, because npm won't update it unless the version number changes.

Use the published version for dogfooding so it can be installed from npm.
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
* Update dependencies

* Use published version of eslint-config-react-app for development

We dogfood on our eslint-config-react-app by using it as our ESLint config,
but installing it from the local folder causes problems when its peerDependencies
are updated, because npm won't update it unless the version number changes.

Use the published version for dogfooding so it can be installed from npm.
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
* Update dependencies

* Use published version of eslint-config-react-app for development

We dogfood on our eslint-config-react-app by using it as our ESLint config,
but installing it from the local folder causes problems when its peerDependencies
are updated, because npm won't update it unless the version number changes.

Use the published version for dogfooding so it can be installed from npm.
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants