Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more sophisticated template for end-to-end testing. #875

Closed
wants to merge 1 commit into from
Closed

Use a more sophisticated template for end-to-end testing. #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/create-react-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ if (commands.length === 0) {
process.exit(1);
}

createApp(commands[0], argv.verbose, argv['scripts-version']);
createApp(commands[0], argv.verbose, argv['scripts-version'], argv['from-template']);

function createApp(name, verbose, version) {
function createApp(name, verbose, version, templatePath) {
var root = path.resolve(name);
var appName = path.basename(root);

Expand Down Expand Up @@ -104,10 +104,10 @@ function createApp(name, verbose, version) {
console.log('Installing react-scripts from npm...');
console.log();

run(root, appName, version, verbose, originalDirectory);
run(root, appName, version, verbose, originalDirectory, templatePath);
}

function run(root, appName, version, verbose, originalDirectory) {
function run(root, appName, version, verbose, originalDirectory, templatePath) {
var installPackage = getInstallPackage(version);
var packageName = getPackageName(installPackage);
var args = [
Expand All @@ -134,7 +134,7 @@ function run(root, appName, version, verbose, originalDirectory) {
'init.js'
);
var init = require(scriptsPath);
init(root, appName, verbose, originalDirectory);
init(root, appName, verbose, originalDirectory, templatePath);
});
}

Expand Down
1 change: 1 addition & 0 deletions packages/react-scripts/kitchensink/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
REACT_APP_ENV_FILE_MESSAGE=fromtheenvfile
8 changes: 8 additions & 0 deletions packages/react-scripts/kitchensink/.flowconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[ignore]
<PROJECT_ROOT>/node_modules/fbjs/.*

[include]

[libs]

[options]
Loading