Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate that the file structure is the template's #8561

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Indicate that the file structure is the template's #8561

merged 1 commit into from
Feb 29, 2020

Conversation

Vinnl
Copy link
Contributor

@Vinnl Vinnl commented Feb 27, 2020

The directory tree that's currently shown is the structure that a CRA template should have, but my-app is used earlier in this tutorial to refer to the app that's generated based on that template.

mrmckeb
mrmckeb approved these changes Feb 29, 2020
View reviewed changes
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst this is not actually required - only the published name needs to be in this format - I think this makes sense.

@mrmckeb mrmckeb merged commit 7d3b72c into facebook:master Feb 29, 2020
@mrmckeb
Copy link
Contributor

mrmckeb commented Feb 29, 2020

Merged, thanks @Vinnl!

@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
@ianschmitz ianschmitz added this to the 3.4.1 milestone Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrmckeb mrmckeb mrmckeb approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@iansu iansu Awaiting requested review from iansu

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Vinnl @mrmckeb @ianschmitz @facebook-github-bot