Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxying API request docs #8515

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Conversation

hjr3
Copy link
Contributor

@hjr3 hjr3 commented Feb 19, 2020

The http-proxy-middleware package has made a major version upgraded and
introduced a breaking change. This fixes the "Configuring the Proxy
Manually" docuementation to match the latest version.

Relates to #8513

The http-proxy-middleware package has made a major version upgraded and
introduced a breaking change. This fixes the "Configuring the Proxy
Manually" docuementation to match the latest version.
@facebook-github-bot
Copy link

Hi @hjr3!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link

@mindhaq mindhaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on a similar setup.

@averypmc
Copy link

Please merge! This was helpful.

@ianschmitz ianschmitz added this to the 3.4.1 milestone Mar 4, 2020
@ianschmitz ianschmitz merged commit 3f699fd into facebook:master Mar 4, 2020
@ianschmitz
Copy link
Contributor

Thanks!

@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants