Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle service worker error in Firefox #8272

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Handle service worker error in Firefox #8272

merged 2 commits into from
Jan 31, 2020

Conversation

rosinghal
Copy link
Contributor

@facebook-github-bot
Copy link

Hi rosinghal! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

andriijas
andriijas suggested changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@andriijas andriijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please also update cra-template/template/src/serviceWorker.js

Thanks

@rosinghal
Copy link
Contributor Author

@andriijas done

@andriijas andriijas added this to the 3.4 milestone Jan 31, 2020
@andriijas andriijas merged commit 3190e4f into facebook:master Jan 31, 2020
@andriijas
Copy link
Contributor

Thanks!

@rosinghal rosinghal deleted the patch-1 branch January 31, 2020 16:09
@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andriijas andriijas andriijas requested changes

@awibox awibox awibox approved these changes

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: bug fix tag: enhancement
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@rosinghal @facebook-github-bot @andriijas @awibox