-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup @babel/plugin-transform-destructuring configuration #8215
cleanup @babel/plugin-transform-destructuring configuration #8215
Conversation
I think |
Yep. I noticed that PR and don't see any activity on it. |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
I noticed it was marked as stale. I still think this is a valid PR. |
If we decided to get rid of the customization, we can remove the plugin entirely as it's provided by |
Thanks for bringing this to our attention! I took a slightly different approach in #8353, and removed it entirely. I included you as a co-author so you get credit as well 👍 |
thanks @ianschmitz! |
The
@babel/plugin-transform-destructuring
Babel plugin does not have aselectiveLoose
option currently and this code has been a source of confusion for me and possibly others. It was introduced in #5997 and I'm not sure if the intention was to wait for theselectiveLoose
option to be available. Even if this worked as hoped for I think that onlyuseState
anduseReducer
should be targeted for this optimization.Thanks! Please let me know if I'm missing something obvious.