Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove double coerce #7882

Merged
merged 1 commit into from
Oct 27, 2019
Merged

refactor: remove double coerce #7882

merged 1 commit into from
Oct 27, 2019

Conversation

mrmckeb
Copy link
Contributor

@mrmckeb mrmckeb commented Oct 25, 2019

A small change, this doesn't require a release/update to the current beta for templates.

The packageVersion was already coerced on line 445. I've also added a note to remove the env variable post official release.

@ianschmitz
Copy link
Contributor

Ah yes. Hasty conference commits. Whoops! 😛

@ianschmitz ianschmitz merged commit 971f249 into master Oct 27, 2019
@ianschmitz ianschmitz deleted the fix/double-coerce branch October 27, 2019 04:02
@mrmckeb
Copy link
Contributor Author

mrmckeb commented Oct 27, 2019

Absolutely fine! I'm just glad we got this monster over the line haha.

@lock lock bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants