Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(svg): add tip for title props accessibility #7374

Merged
merged 1 commit into from
Jul 15, 2019
Merged

docs(svg): add tip for title props accessibility #7374

merged 1 commit into from
Jul 15, 2019

Conversation

sudkumar
Copy link
Contributor

With #7118 being merged, we can now pass a title prop to the SVG ReactComponent to make
our SVG component easily accessible. So we should add it to docs

@sudkumar
docs(svg): add tip for title props
01f9daa 
With #7118 being
merged, we can now pass a title prop to the SVG ReactComponent to make
our SVG component easily accessible. So we should add it to docs
@sudkumar sudkumar mentioned this pull request Jul 15, 2019
Merged
@iansu iansu added this to the 3.0.2 milestone Jul 15, 2019
@iansu iansu merged commit 3a9b87b into facebook:master Jul 15, 2019
@iansu
Copy link
Contributor

iansu commented Jul 15, 2019

Thanks!

@sudkumar sudkumar deleted the docs branch July 20, 2019 03:23
@mrmckeb
Copy link
Contributor

mrmckeb commented Jul 22, 2019

Amazing, thanks @sudkumar (and for reviewing @iansu).

@lock lock bot locked and limited conversation to collaborators Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam

@iansu iansu Awaiting requested review from iansu

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@sudkumar @iansu @mrmckeb @facebook-github-bot