Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terser-webpack-plugin hanging on WSL #6732

Merged
merged 3 commits into from
Apr 5, 2019
Merged

fix: terser-webpack-plugin hanging on WSL #6732

merged 3 commits into from
Apr 5, 2019

Conversation

endiliey
Copy link
Contributor

Motivation

Fix #6723

When running react-scripts build on Windows Subsystem for Linux, the webpack build will hang during the uglifying step. This is caused due to a bug on terser not being able to run in parallel on WSL
(webpack-contrib/terser-webpack-plugin#21)

This PR attempts to disable parallel run on WSL until that bug is fixed upstream

@iansu
Copy link
Contributor

iansu commented Apr 4, 2019

Please resolve merge conflicts.

@endiliey
Copy link
Contributor Author

endiliey commented Apr 5, 2019

@iansu seems that a kind hearted @bugzpodder has done that. Thank you 👍

@iansu iansu merged commit 3e336d9 into facebook:master Apr 5, 2019
@iansu
Copy link
Contributor

iansu commented Apr 5, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WSL react-scripts build hangs when terser parallel is true
3 participants