Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change app component declaration from arrow function to regular function #6655

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Mar 15, 2019

Small update to the default templates to keep them consistent with the React docs.

@amshtemp
Copy link

@iansu
function App(): React.FC { }
vs.
const App: React.FC = () => {}

aren't those different (return type vs function type)?

@iansu
Copy link
Contributor Author

iansu commented Mar 17, 2019

@amshtemp Yes they are different. We're probably going to change the TypeScript template back to an arrow function.

Copy link
Contributor

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iansu iansu merged commit b424737 into facebook:master Mar 19, 2019
@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
@iansu iansu deleted the template-fixes branch October 17, 2019 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants