Fix CI and upgrade dependencies

[Timer]

No description provided.

[matthewdavidson]

Hey @Timer, I maintain a fork of react-scripts called backpack-react-scripts and we are running into a similar issue that this PR has fixed on facebook/create-react-app.

./src/index.js
Error: [BABEL] /tmp/tmp.3m0bzS6x1k/test-app/src/index.js: Cannot find module '@babel/plugin-transform-react-jsx' (While processing: "/tmp/tmp.3m0bzS6x1k/test-app/node_modules/babel-preset-react-app/index.js$1")
    at Array.reduce (<anonymous>)

After rebasing on top of this commit I still get the issue - do you have any ideas on how to fix this? It seems that by simply modifying react-scripts dependencies is enough to upset the dependency graph enough to cause this error. See example commit and build.

[Timer]

Hey @matthewdavidson, can you try clearing your Travis cache?

[matthewdavidson]

I removed all caches and re ran the build. Same issue unfortunately. The build passes before I rebase, it's just as soon as I modify the dependencies in react-scripts...

[Timer]

Hmm, very interesting. We had narrowed this down to an issue with the Yarn nightlies and it was actually fixed by switching to Yarn stable.

Are you accidentally changing the build back to nightly?

[matthewdavidson]

Yeah when I seen the fix upstream I initially only included the change to switch back to Yarn stable. You can see the commit log here. The only major difference is the addition of some new dependencies...

[Timer]

Truth be told I don't know what's wrong. Maybe try filing an issue with Yarn if you can recreate this locally.

Sorry we can't be of more help.

[matthewdavidson]

Update: I remove the yarn.lock.cached file and commented out the code that copies it. That definitely improved things, see build.

Still the issue remains for two of the kitchensink-eject builds (node 8 & 10, but not node)

[arcanis]

Fyi, this fixes (through the pnp-webpack-plugin upgrade) some compatibility issues between PnP and Windows (cf yarnpkg/yarn#6860 for more info) 🙂

Regarding your issue @matthewdavidson, if you can make a super-easy local repro I can give it a look, but otherwise I'm not aware of issues with packages not installed (I would assume it would have been raised before otherwise) 😕

[Bnaya]

When dose it scheduled to be released? :)