Create .babelrc file on eject #602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -9,38 +9,66 @@ | |||
| */ | |||
| // @remove-on-eject-end | |||
|
|
|||
|
|
|||
| // After eject | |||
| module.exports = function () { | |||
There was a problem hiding this comment.
This file existing in a trimmed down state is somewhat confusing. Can we embed this single option into the Webpack config and instead branch there? You could use Object.assign() to merge options if necessary.
| @@ -88,10 +70,31 @@ prompt( | |||
| }; | |||
|
|
|||
| fs.writeFileSync( | |||
| path.join(appPath, 'config', '.babelrc'), | |||
| path.join(ownPath, 'config', '.babelrc'), | |||
There was a problem hiding this comment.
Needs to be changed so that a file isn't created in ownPath
|
Sorry for the churn, transitioning to a monorepo was a big but necessary change. |
|
Cool, l think that will be much better. |
|
I’m closing in favor of the approach in #705. Sorry this PR didn’t get in! I hope this doesn’t discourage you from future contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at addressing #410
After ejecting, a
.babelrcfile is generated and extended in the app'spackage.json. This means additional config options can be added in a familiar way. Additionally, editor plugins that rely on a standard babel config setup will work.babel.dev.jsandbabel.prod.jsare modified to export functions which conditionally userequire.resolve()for paths.The generated
.babelrcuses theenvflag to separate development and production configs. The configs are similar, but I haven't merged them to keep them extensible, and the pull request simpler.Edit: e2e now passes