-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set packageName in TypeScript reference file #5827
Set packageName in TypeScript reference file #5827
Conversation
Update from upstream repo facebook/create-react-app@master
Update from upstream repo facebook/create-react-app@master
Update from upstream repo facebook/create-react-app@master
Update from upstream repo facebook/create-react-app@master
Update from upstream repo facebook/create-react-app@master
Update from upstream repo facebook/create-react-app@master
Update from upstream repo facebook/create-react-app@master
Update from upstream repo facebook/create-react-app@master
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Hmm, this would break existing apps adding TypeScript. We just need to parse it from |
This PR is sent as suggested by @Timer here:
#5811
Here are the full steps that I used to test:
@devloco/react-scripts-test
create-react-app/packages/create-react-app
npm link
(to pick up the changes made to createReactApp.js)cd ~/temp
create-react-app foo1 --typescript --scripts-version @devloco/react-scripts-test
cd foo1/src
vim react-app-env.d.ts
@devloco/react-scripts-test
:q!
+ ENTER to exit vimyarn start
Screenshots:
Make sure that not using --scripts-version still works the same
cd ~/temp
cd foo2/src
vim react-app-env.d.ts
react-scripts
:q!
+ ENTER to exit vimyarn start