Clarify proxy instructions in generated app README #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -488,15 +488,15 @@ To tell the development server to proxy any unknown requests to your API server | |||
| "proxy": "http://localhost:4000", | |||
| ``` | |||
|
|
|||
| This way, when you `fetch('/api/todos')` in development, the development server will recognize that it’s not a static asset, and will proxy your request to `http://localhost:4000/api/todos` as a fallback. | |||
| This way, when you `fetch('/api/todos')` in development, the development server will recognize that it’s not a static asset, and will proxy your request to `http://localhost:4000/api/todos` as a fallback. The development server will only attempt to send requests without a text/html accept header to the proxy. | |||
There was a problem hiding this comment.
Can you please put text/html into backticks?
|
Thanks. |
stayradiated
pushed a commit
to stayradiated/create-react-app
that referenced
this pull request
Sep 7, 2016
* Clarify proxy instructions in generated app README * Add backticks to format text/html as code
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
* Clarify proxy instructions in generated app README * Add backticks to format text/html as code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update instructions for
proxyfeature added in #282 to clarify that requests with text/html accept header will not be proxied.Related to #523.