Don't crash npm test when hg/git are missing #5212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer
reviewed
Oct 1, 2018
| @@ -31,15 +31,36 @@ if (process.env.SKIP_PREFLIGHT_CHECK !== 'true') { | |||
| // @remove-on-eject-end | |||
|
|
|||
| const jest = require('jest'); | |||
| const execSync = require('child_process').execSync; | |||
There was a problem hiding this comment.
Should this use react-dev-utils/crossSpawn?
There was a problem hiding this comment.
I dunno. I copy pasted from init.js. That's what we use there. Should I worry?
There was a problem hiding this comment.
We also use it in CRA itself for detecting yarn. I think it's fine.
Jest uses |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5210 with a clunky workaround.
I hope this more or less matches the Jest logic.