Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output CSS sourcemaps in separate file #5131

Merged
merged 2 commits into from
Sep 27, 2018
Merged

Output CSS sourcemaps in separate file #5131

merged 2 commits into from
Sep 27, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Sep 27, 2018

Fixes #5120

@Timer Timer added this to the 2.0.0 milestone Sep 27, 2018
gaearon
gaearon approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to leave a comment for why these options

@Timer
Copy link
Contributor Author

Timer commented Sep 27, 2018

Added comments

@Timer Timer merged commit fed4100 into facebook:master Sep 27, 2018
@Timer Timer deleted the css-source-maps branch September 27, 2018 13:13
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@Timer
Output CSS sourcemaps in separate file (facebook#5131)
59b51e0 
* Output CSS sourcemaps in separate file

* explain options
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @gaearon @facebook-github-bot