Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade svgr to v2 and disable Prettier & SVGO #5062

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Sep 21, 2018

Continuation of #4799 by @kopacki.

This updates svgr and disables Prettier / SVGO.

Prettier is disabled because it just increases compile-time latency, there's no true benefit here.

SVGO is disabled because there's no "safe defaults" that keep it useful IMO, and we don't apply optimizations to SVGs imported as URLs.
Different optimization behavior based on how the SVG is imported would be confusing/unexpected to the user, especially during debugging.

If we go down the SVGO path, we'll probably only do it for Production and for both ReactComponents and URLs.

This PR will be a great first step.

@Timer Timer added this to the 2.0.0 milestone Sep 21, 2018
@Timer Timer merged commit 2150693 into facebook:next Sep 21, 2018
@Timer Timer deleted the svg-upgrade branch September 21, 2018 20:00
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants