Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to cheap-module-source-map #5059

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Conversation

jasonLaster
Copy link
Contributor

Follow up #4930

It looks like chrome stable and safari fail to show the error overlay with eval-source-map. Based on that, I think we should likely switch back to cheap-module-source-map for the time being.

@Timer
Copy link
Contributor

Timer commented Sep 21, 2018

😭

@Timer Timer added this to the 2.0.0 milestone Sep 21, 2018
@Timer Timer merged commit 78f0a96 into facebook:next Sep 21, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants