Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove name from splitChunks settings (#4769) #4772

Closed
wants to merge 1 commit into from
Closed

Remove name from splitChunks settings (#4769) #4772

wants to merge 1 commit into from

Conversation

TLadd
Copy link

@TLadd TLadd commented Jul 16, 2018

Pulled my fork of react-scripts in and ran yarn build --stats && webpack-bundle-analyzer build/bundle-stats.json. Can read about the details of this change in #4769, which also has a more thorough example of the effects of this webpack config change.

The source for the below screenshot has one dynamic import import("zxcvbn")

Before:
Imgur

After:
Imgur

Notice that 0.b6c8f3e4.chunk.js is split out of the vendor chunk, which contains zxcvbn.

@Timer
Copy link
Contributor

Timer commented Sep 19, 2018

Replaced by d555256; thank you for the inspiration!

@Timer Timer closed this Sep 19, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants