-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add info about service-worker and HTTP caching headers into Firebase section #3659
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Seriously, Firebase is still not doing this by default? cc @addyosmani @jeffposnick Is this expected? |
@gaearon no, unfort :( And that thing is crucial when deploying to Firebase, because service-worker enabled in create-react-app by default. |
This sounds a bit silly given that Firebase is a Google project and Google's the one pushing for service worker adoption. |
(To clarify, I refer to the situation as silly, not your post) |
I'll agree that it's silly/frustrating, but for different reasons: this configuration shouldn't be necessary anymore, as per the service worker specification, and is no longer necessary in Firefox, which has been updated to ignore HTTP caches for service workers by default. Unfortunately, and as discussed elsewhere, Chrome hasn't yet made that change, though there is at least a changelist under review. Adding this recommendation to the docs for the time being to account for the current behavior of Chrome couldn't hurt. (I wouldn't expect Firebase to make changes to their hosting environment to accommodate Chrome's inconsistent-with-the-spec behavior at this point.) |
Fair, thank you for explaining! I’m sorry I snapped a little. |
Tricky issue, if you not aware on how service-workers work. Related to #2440