Target specific node modules with babel. #3566
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request is motivated by: #1125
From what I gathered from the thread, the only reason node_modules was not included in the babel transpile is because of performance, and the make perfect sense. However, app developers should at least be able to specify what modules they need transpiled.
Each module inside node_modules the applications requires to be transpiled can be specified in the applications
package.json
through the new propertytranspileDependencies
.Example
According to CONTRIBUTING.md this goes against the Core Ideas of the software, but I couldn't think of a better way (with my limited knowledge of this software) to implement this. Perhaps this will just serve as a concept.
Initially I wanted to make these changes to
packages/react-scripts/config/paths.js
as that is where most paths are kept, however, this is a dynamic list of paths, so I opted to add the code into each webpack config file.Test Plan
Not the most ideal, but I verified this change with the following steps
npm run create-react-app my-app
cd my-app
npm install @my-org/some-es6-module
npm start
/npm run build