-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add —use-npm flag to bypass yarn #3409
Conversation
Yes, this should work. We can add a test for this in the e2e tests though. Checking if a |
Yeah that's a great idea. Will add. |
Hello! I'm a bot that helps facilitate testing pull requests. Your pull request (commit 547ad01) has been released on npm for testing purposes. npm i react-scripts-dangerous@1.0.17-547ad01.0
# or
yarn add react-scripts-dangerous@1.0.17-547ad01.0
# or
create-react-app --scripts-version=react-scripts-dangerous@1.0.17-547ad01.0 folder/ Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk! Thanks for your contribution! |
# ****************************************************************************** | ||
|
||
cd "$temp_app_path" | ||
create_react_app --use-npm --scripts-version=0.4.0 test-use-npm-flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to install a specific version here.
This looks good to go. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't hurt 😄
Thanks! |
* add —use-npm flag to bypass yarn * add e2e test for —use-npm flag
This option should be documented, ref jestjs/jest#5119 (comment) |
Should probably be documented, but tbh, I'm trash for not gaearon said something about not wanting to add flags a while back (albeit, in reference to adding a |
What's the preferred way of using this flag on an existing project? I already have a CRA but I am wanting to opt out from yarn. How do I go about? |
@AmitJoki Delete your |
* add —use-npm flag to bypass yarn * add e2e test for —use-npm flag
Allow user to choose npm over yarn. This should close #3385.