Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint 4 #2735

Merged
merged 5 commits into from
Jul 7, 2017
Merged

ESLint 4 #2735

merged 5 commits into from
Jul 7, 2017

Conversation

trungdq88
Copy link
Contributor

Changes

  • Upgrades eslint-loader from 1.7.1 -> 1.9.0.
  • Add eslintPath option to eslint-loader
  • Upgrades ESLint from 3.19.0 to 4.1.1
  • Upgrades the unmet dependencies of ESlint 4.1.1.

Resolve related issues: #2528, #2604, #2631

Tested with issue #2528, verify with following script:

npm run create-react-app verify-issue-2528
cd verify-issue-2528
yarn add eslint
vim src/App.js # Add prop types to App.js

#  static propTypes = {
#    aoeu: React.PropTypes.any,
#  }

yarn run build # Should build success :tada:

Screenshot

image

Tests

Passed: https://travis-ci.org/trungdq88/create-react-app/builds/250878659

@trungdq88 trungdq88 mentioned this pull request Jul 6, 2017
Closed
gaearon
gaearon reviewed Jul 6, 2017
View reviewed changes
packages/react-scripts/config/webpack.config.dev.js Outdated
@@ -142,6 +142,7 @@ module.exports = {
},
ignore: false,
useEslintrc: false,
eslintPath: require.resolve('eslint'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move this outside of @remove-on-eject.

gaearon
gaearon reviewed Jul 6, 2017
View reviewed changes
packages/react-scripts/config/webpack.config.prod.js Outdated
@@ -144,6 +144,7 @@ module.exports = {
},
ignore: false,
useEslintrc: false,
eslintPath: require.resolve('eslint'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@gaearon gaearon added this to the 1.0.11 milestone Jul 7, 2017
@gaearon
Copy link
Contributor

gaearon commented Jul 7, 2017

I think this looks good. Thank you!

@gaearon gaearon merged commit bbbc15d into facebook:master Jul 7, 2017
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
@trungdq88 @romaindso
ESLint 4 (facebook#2735)
7ae1ebe 
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject
JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Aug 9, 2017
@trungdq88 @JohnNilsson
ESLint 4 (#2735)
408fa37 
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
@trungdq88 @morgs32
ESLint 4 (facebook#2735)
00f6be3 
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject
JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Sep 9, 2017
@trungdq88 @JohnNilsson
ESLint 4 (#2735)
63e8924 
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017
@trungdq88 @kasperpeulen
ESLint 4 (facebook#2735)
f64c910 
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject
swengorschewski referenced this pull request in swengorschewski/cra-typescript-electron Oct 16, 2017
@trungdq88 @swengorschewski
ESLint 4 (#2735)
0242f91 
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaearon gaearon gaearon left review comments

Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
1.0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@trungdq88 @gaearon @facebook-github-bot