Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint: set allowTaggedTemplates to true #2701

Merged
merged 1 commit into from
Jul 1, 2017
Merged

ESLint: set allowTaggedTemplates to true #2701

merged 1 commit into from
Jul 1, 2017

Conversation

denkristoffer
Copy link
Contributor

This PR should address #2647 by allowing tagged templates. This avoids ESLint warning about styled-components's injectGlobal.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Jul 1, 2017

@mxstbr @geelen Can you confirm there’s no plans to change injectGlobal API?

@mxstbr
Copy link
Contributor

mxstbr commented Jul 1, 2017

No plans to change it.

@mxstbr
Copy link
Contributor

mxstbr commented Jul 1, 2017

This warning's been annoying me for ages so I'd love for this to land!

@gaearon gaearon added this to the 1.0.11 milestone Jul 1, 2017
@gaearon gaearon merged commit df00d80 into facebook:master Jul 1, 2017
@gaearon
Copy link
Contributor

gaearon commented Jul 1, 2017

Seems fine, thanks!

@gaearon
Copy link
Contributor

gaearon commented Jul 1, 2017

Also please report other annoying warnings ;-)

romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
@denkristoffer @romaindso
allowTaggedTemplates to avoid warnings from SC's (facebook#2701)
9b2b24a
@Timer
Copy link
Contributor

Timer commented Aug 9, 2017

Hi there! This change is out in react-scripts@1.0.11; please give it a go! Thanks.

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Aug 9, 2017
@denkristoffer @JohnNilsson
allowTaggedTemplates to avoid warnings from SC's (#2701)
5a3a525
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
@denkristoffer @morgs32
allowTaggedTemplates to avoid warnings from SC's (facebook#2701)
85e4237
JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Sep 9, 2017
@denkristoffer @JohnNilsson
allowTaggedTemplates to avoid warnings from SC's (#2701)
c8cb004
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017
@denkristoffer @kasperpeulen
allowTaggedTemplates to avoid warnings from SC's (facebook#2701)
39fdefa
swengorschewski referenced this pull request in swengorschewski/cra-typescript-electron Oct 16, 2017
@denkristoffer @swengorschewski
allowTaggedTemplates to avoid warnings from SC's (#2701)
677b613
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
1.0.11
Development

Successfully merging this pull request may close these issues.
5 participants
@denkristoffer @facebook-github-bot @gaearon @mxstbr @Timer