-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Use Pundle as the module bundler #268
Conversation
@@ -39,32 +38,25 @@ | |||
"babel-preset-es2015": "6.9.0", | |||
"babel-preset-es2016": "6.11.3", | |||
"babel-preset-react": "6.11.1", | |||
"babel-pundle": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the other requirements here are fixed versions instead of ^
, probably it's better to do the same for pundle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Does pundle support any sort of built-in proxying behavior? We need something like that to support backend servers. If we used pundle instead of webpack, do you think pundle should also be used to package files for the test environment? Or is that not a good fit for pundle? |
const debugInfo = debug('REACT-APP:Info') | ||
const debugError = debug('REACT-APP:Error') | ||
|
||
const port = 8056 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be process.env.PORT || 3000
?
You would want to change |
Pundle supports fully configurable bundle paths (including their source map and hmr paths) so it's very easy to use it behind a proxy. In fact we're already using it in our dev environment. Also Pundle has two main external components, The Dev Server and the main CLI, it can compile anything and probably more than what webpack is capable of :) Also I'm working on transitioning |
Would love to see production build sizes and benchmarks on the page speed. |
This doesn’t currently handle styles, does it? |
This is build time in Pundle vs Webpack (respectively) That's like a 2.3x boost. Pundle is especially fast at HMR, it's HMRs are near-instant. @gaearon Yeah it's being actively worked on, as the ETA it's happening soon :) |
Closing as outdated, but feel free to reopen when there is a reasonable feature parity! |
I wonder if there is any update on this. ? |
fix(readme): use the prepacked logo.svg as an example in "Adding Imag…
Reference: #93 (comment)
This PR uses the Pundle module bundler instead of Webpack
What's working?
What needs some work?
I will be implementing the missing plugins for Pundle as we make progress on this PR
What's the benefit?
Well documented and maintained software that has extremely fast bundling and hot reload speed compared to Webpack
cc @gaearon