Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warning when trying to run on port below 1024 without admin permissions under Linux/macOS #2518

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Show warning when trying to run on port below 1024 without admin permissions under Linux/macOS #2518

merged 1 commit into from
Jun 19, 2017

Conversation

levrik
Copy link
Contributor

@levrik levrik commented Jun 11, 2017 •
edited
Loading

On Linux/macOS (and WSL too) it requires admin permissions to run a server on a port below 1024.
I'm shifting my development stuff to WSL on Windows at the moment and didn't know that so it would be nice to show another message in this case.

image

  • Tested on WSL
  • Tested on Linux
  • Tested on macOS (I cannot do this. No Mac.)

ref #2512

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@levrik levrik changed the title Show warning when trying to run on port below 1024 without admin permissions under Linux Show warning when trying to run on port below 1024 without admin permissions under Linux/macOS Jun 11, 2017
@afontcu
Copy link

afontcu commented Jun 15, 2017

Warning shows up in a Mac (OS X 10.11 with ohmyzsh).

Mac OS port <1024 warning

@levrik
Copy link
Contributor Author

levrik commented Jun 15, 2017

@afontcu Thank you for testing. PR is ready now.

@trueadm trueadm self-requested a review June 19, 2017 15:53
trueadm
trueadm approved these changes Jun 19, 2017
View reviewed changes
Copy link

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thank you for this!

@trueadm trueadm added this to the 1.0.8 milestone Jun 19, 2017
@trueadm trueadm merged commit b1c0faa into facebook:master Jun 19, 2017
@levrik levrik deleted the improve-port-warning branch June 19, 2017 16:37
@gaearon gaearon mentioned this pull request Jun 28, 2017
Merged
@gaearon
Copy link
Contributor

gaearon commented Jun 28, 2017

Fixed in 1.0.8. Please verify.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.0.8

romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
@levrik @romaindso
Show warning when trying to run on port below 1024 without admin perm…
8018b31 
…issions under Linux (facebook#2518)
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
@levrik @wmonk
Show warning when trying to run on port below 1024 without admin perm…
d68ed30 
…issions under Linux (#2518)
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
1.0.8
Development

Successfully merging this pull request may close these issues.
5 participants
@levrik @facebook-github-bot @afontcu @gaearon @trueadm