-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unscope detect-port #2483
Merged
Merged
Unscope detect-port #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
approved these changes
Jun 6, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k
@Timer Just out of curiosity, what do you mean by that? |
Scoped packages are an npm (the CLI) feature but it seems every custom registry in existence doesn't support them yet. |
paweljedrzejczyk
pushed a commit
to paweljedrzejczyk/create-react-app
that referenced
this pull request
Jun 12, 2017
* Update Travis CI Node versions in User Guide (facebook#2454) Removed Node v4 (CRA only supports Node >= 6) * re-add storybook && update the documentation and links (facebook#2331) * re-add storybook && update the documentation and links * Change to new documentation domain * Prioritize index.css over the implicit App.css (facebook#2470) * Added NamedModulesPlugin in webpack.config.dev.js (facebook#2458) * Added NamedModulesPlugin in webpack.config.dev.js * Update webpack.config.dev.js * Unscope detect-port (facebook#2483) Resolves facebook#2481 * Update webpack links to point to webpack 2 (facebook#2492) * Update README.md to make links to webpack point to webpack.js.org instead insteade of webpack 1 webpack.githup.io * chore(templates): Move GitHub templates to hidden .github folder (facebook#2489) * Fix minor docs typo (facebook#2500) * Fix link to Storybook docs (facebook#2521) * Simplify flow init docs (facebook#2522) - Call `npm run flow --init` won't create a .flowconfig file, it should be `npm run flow init`
Merged
romaindso
pushed a commit
to romaindso/create-react-app
that referenced
this pull request
Jul 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unscopes
detect-port
because the ecosystem is not yet ready for scoped packages.