Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for the overlay #2118

Merged
merged 9 commits into from
May 11, 2017
Merged

Adds tests for the overlay #2118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
90357c7
Add get-source-map tests
Timer May 11, 2017
b21089a
Fixtures shouldn't be formatted
Timer May 11, 2017
25d8cbe
Add mapper tests
Timer May 11, 2017
09be002
Add stack-frame tests
Timer May 11, 2017
1079738
Add more util tests
Timer May 11, 2017
ddd5988
Add unmapper tests
Timer May 11, 2017
5c3a5e4
Add parser tests
Timer May 11, 2017
4f568f2
Switch to snapshots
Timer May 11, 2017
4031496
Snapshot more
Timer May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions packages/react-error-overlay/fixtures/bundle-default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify the role of JSON files compared to snapshots?

{
"functionName": "App.componentDidMount",
"fileName": "http://localhost:3000/static/js/bundle.js",
"lineNumber": 26122,
"columnNumber": 21,
"_originalFunctionName": "App.componentDidMount",
"_originalFileName": "webpack:///packages/react-scripts/template/src/App.js",
"_originalLineNumber": 7,
"_originalColumnNumber": 0,
"_scriptCode": [
{
"lineNumber": 26119,
"content": " _createClass(App, [{",
"highlight": false
},
{
"lineNumber": 26120,
"content": " key: 'componentDidMount',",
"highlight": false
},
{
"lineNumber": 26121,
"content": " value: function componentDidMount() {",
"highlight": false
},
{
"lineNumber": 26122,
"content": " document.body.missing();",
"highlight": true
},
{
"lineNumber": 26123,
"content": " }",
"highlight": false
},
{
"lineNumber": 26124,
"content": " }, {",
"highlight": false
},
{
"lineNumber": 26125,
"content": " key: 'render',",
"highlight": false
}
],
"_originalScriptCode": [
{
"lineNumber": 4,
"content": "",
"highlight": false
},
{
"lineNumber": 5,
"content": "class App extends Component {",
"highlight": false
},
{
"lineNumber": 6,
"content": " componentDidMount() {",
"highlight": false
},
{
"lineNumber": 7,
"content": " document.body.missing()",
"highlight": true
},
{
"lineNumber": 8,
"content": " }",
"highlight": false
},
{
"lineNumber": 9,
"content": "",
"highlight": false
},
{
"lineNumber": 10,
"content": " render() {",
"highlight": false
}
]
}
]
Loading